Subject: Re: alpha still generates a warning
From: Christoph Lameter <[email-masked]>
To: Andrew Morton <[email-masked]>
Date: Sat, 30 Jul 2005 23:11:24 -0700 (PDT)

On Sat, 30 Jul 2005, Andrew Morton wrote:

> nope.
> 
> 
>   CC      arch/alpha/kernel/asm-offsets.s
> In file included from include/asm/pgtable.h:365,
>                  from include/asm/io.h:10,
>                  from arch/alpha/kernel/asm-offsets.c:11:
> include/asm-generic/pgtable.h:294:1: "pud_test_and_populate" redefined
> In file included from include/asm/pgtable.h:4,
>                  from include/asm/io.h:10,
>                  from arch/alpha/kernel/asm-offsets.c:11:
> include/asm-generic/4level-fixup.h:30:1: this is the location of the previous definition
> 

Crap. Remove the definition of pud_test_and_populate (It is likely 
provided by the fallback on alpha) and just keep pgd_populate. I wish I 
had a way to run a compile on an alpha.

Index: linux-2.6.13-rc4/include/asm-generic/4level-fixup.h
===================================================================
--- linux-2.6.13-rc4.orig/include/asm-generic/4level-fixup.h	2005-07-30 19:20:08.000000000 -0700
+++ linux-2.6.13-rc4/include/asm-generic/4level-fixup.h	2005-07-30 23:11:12.000000000 -0700
@@ -26,6 +26,7 @@
 #define pud_present(pud)		1
 #define pud_ERROR(pud)			do { } while (0)
 #define pud_clear(pud)			pgd_clear(pud)
+#define pud_populate			pgd_populate
 
 #undef pud_free_tlb
 #define pud_free_tlb(tlb, x)            do { } while (0)